perf(mangler): turn off scope_tree_child_ids for SemanticBuilder#18122
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
1bd2e0d to
8366ee4
Compare
8366ee4 to
aad5764
Compare
SemanticBuilderscope_tree_child_ids for SemanticBuilder
aad5764 to
53779b3
Compare
7c4f44f to
17591fa
Compare
Merge activity
|
17591fa to
727939f
Compare
…18122) I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
53779b3 to
c61e6d9
Compare
…18122) I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
c61e6d9 to
3c7cd5d
Compare
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Mangler by disabling the generation of child scope IDs in the SemanticBuilder, which were not actually needed by the Mangler's implementation.
Changes:
- Removed
.with_scope_tree_child_ids(true)fromSemanticBuildercalls in both thebuild()method and benchmark - Removed the assertion that verified child scope IDs were present
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_mangler/src/lib.rs | Removed scope tree child IDs requirement from semantic builder and deleted the related assertion |
| tasks/benchmark/benches/minifier.rs | Removed scope tree child IDs flag from benchmark's semantic builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…18122) I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
3c7cd5d to
9af52c6
Compare

I discovered that
Manglerno longer needs to generate child scope IDs, so I disabled it.