Skip to content

perf(mangler): turn off scope_tree_child_ids for SemanticBuilder#18122

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder
Jan 19, 2026
Merged

perf(mangler): turn off scope_tree_child_ids for SemanticBuilder#18122
graphite-app[bot] merged 1 commit intomainfrom
01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 17, 2026

I discovered that Mangler no longer needs to generate child scope IDs, so I disabled it.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jan 17, 2026
Copy link
Member Author

Dunqing commented Jan 17, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder (3c7cd5d) with main (727939f)1

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks2

Footnotes

  1. No successful run was found on main (1073a6d) during the generation of this report, so 727939f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 1bd2e0d to 8366ee4 Compare January 17, 2026 13:45
@github-actions github-actions bot added the A-minifier Area - Minifier label Jan 17, 2026
@Dunqing Dunqing force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch 4 times, most recently from 8366ee4 to aad5764 Compare January 18, 2026 12:19
@Dunqing Dunqing changed the title perf(mangler): turn off scope_tree_child_ids for SemanticBuilder perf(mangler): turn off scope_tree_child_ids for SemanticBuilder Jan 19, 2026
@Dunqing Dunqing marked this pull request as ready for review January 19, 2026 02:09
@Dunqing Dunqing force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch from aad5764 to 53779b3 Compare January 19, 2026 02:16
@Dunqing Dunqing force-pushed the 01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_ branch from 7c4f44f to 17591fa Compare January 19, 2026 02:16
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 19, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_ branch from 17591fa to 727939f Compare January 19, 2026 04:54
graphite-app bot pushed a commit that referenced this pull request Jan 19, 2026
…18122)

I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
@graphite-app graphite-app bot force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 53779b3 to c61e6d9 Compare January 19, 2026 04:55
Base automatically changed from 01-16-refactor_linter_mangler_get_reference_scope_by_reference.scope_id_ to main January 19, 2026 05:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Dunqing added a commit that referenced this pull request Jan 19, 2026
…18122)

I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
Copilot AI review requested due to automatic review settings January 19, 2026 05:31
@Dunqing Dunqing force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch from c61e6d9 to 3c7cd5d Compare January 19, 2026 05:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the Mangler by disabling the generation of child scope IDs in the SemanticBuilder, which were not actually needed by the Mangler's implementation.

Changes:

  • Removed .with_scope_tree_child_ids(true) from SemanticBuilder calls in both the build() method and benchmark
  • Removed the assertion that verified child scope IDs were present

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_mangler/src/lib.rs Removed scope tree child IDs requirement from semantic builder and deleted the related assertion
tasks/benchmark/benches/minifier.rs Removed scope tree child IDs flag from benchmark's semantic builder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
…18122)

I discovered that `Mangler` no longer needs to generate child scope IDs, so I disabled it.
@graphite-app graphite-app bot force-pushed the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch from 3c7cd5d to 9af52c6 Compare January 19, 2026 06:25
@graphite-app graphite-app bot merged commit 9af52c6 into main Jan 19, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 01-17-perf_mangler_turn_off_scope_tree_child_ids_for_semanticbuilder branch January 19, 2026 06:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants