Skip to content

test(linter): Fix a mistake in the test porting.#18120

Merged
graphite-app[bot] merged 1 commit intomainfrom
fix-testt
Jan 17, 2026
Merged

test(linter): Fix a mistake in the test porting.#18120
graphite-app[bot] merged 1 commit intomainfrom
fix-testt

Conversation

@connorshea
Copy link
Member

@connorshea connorshea commented Jan 17, 2026

We want to test the output that results from multiple invalid rules, so we are doing that now.

This was a mistake made in #17600.

Also add a test for rule alias support, to make sure vitest/no-hooks has the same config option validation.

@connorshea connorshea requested a review from camc314 as a code owner January 17, 2026 06:16
Copilot AI review requested due to automatic review settings January 17, 2026 06:16
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a test configuration error where the test_invalid_config_invalid_config_multiple_rules test was pointing to the wrong fixture directory. The test should validate error messages when multiple invalid rule configurations are present.

Changes:

  • Corrected the fixture path in the test from invalid_config_in_override to invalid_config_multiple_rules
  • Added the corresponding snapshot file that captures output for multiple invalid rule configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/src/lint.rs Fixed the test to use the correct fixture directory path matching the test name
apps/oxlint/src/snapshots/fixtures__invalid_config_multiple_rules_@oxlint.snap Added snapshot showing error output for two invalid rule configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@connorshea connorshea added the 0-merge Merge with Graphite Merge Queue label Jan 17, 2026
Copy link
Member Author

connorshea commented Jan 17, 2026

Merge activity

We want to test the output that results from multiple invalid rules, so we are doing that now.

This was a mistake made in #17600.

Also add a test for rule alias support, to make sure vitest/no-hooks has the same config option validation.
@graphite-app graphite-app bot merged commit 8d292b7 into main Jan 17, 2026
19 checks passed
@graphite-app graphite-app bot deleted the fix-testt branch January 17, 2026 06:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants