test(linter): Fix a mistake in the test porting.#18120
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 17, 2026
Merged
test(linter): Fix a mistake in the test porting.#18120graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test configuration error where the test_invalid_config_invalid_config_multiple_rules test was pointing to the wrong fixture directory. The test should validate error messages when multiple invalid rule configurations are present.
Changes:
- Corrected the fixture path in the test from
invalid_config_in_overridetoinvalid_config_multiple_rules - Added the corresponding snapshot file that captures output for multiple invalid rule configurations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src/lint.rs | Fixed the test to use the correct fixture directory path matching the test name |
| apps/oxlint/src/snapshots/fixtures__invalid_config_multiple_rules_@oxlint.snap | Added snapshot showing error output for two invalid rule configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
We want to test the output that results from multiple invalid rules, so we are doing that now. This was a mistake made in #17600. Also add a test for rule alias support, to make sure vitest/no-hooks has the same config option validation.
00851ad to
8d292b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to test the output that results from multiple invalid rules, so we are doing that now.
This was a mistake made in #17600.
Also add a test for rule alias support, to make sure vitest/no-hooks has the same config option validation.