Skip to content

fix(linter): Update react/jsx-max-depth to raise an error if provided invalid config options. #18105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 17, 2026
Merged

fix(linter): Update react/jsx-max-depth to raise an error if provided invalid config options. #18105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions crates/oxc_linter/src/rules/react/jsx_max_depth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ impl std::ops::Deref for JsxMaxDepth {
}

#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
#[serde(rename_all = "camelCase", default)]
#[serde(rename_all = "camelCase", default, deny_unknown_fields)]
pub struct JsxMaxDepthConfig {
/// The maximum allowed depth of nested JSX elements and fragments.
pub max: usize,
}

Expand Down Expand Up @@ -89,9 +90,7 @@ declare_oxc_lint!(

impl Rule for JsxMaxDepth {
fn from_configuration(value: serde_json::Value) -> Result<Self, serde_json::error::Error> {
Ok(serde_json::from_value::<DefaultRuleConfig<Self>>(value)
.map(DefaultRuleConfig::into_inner)
.unwrap_or_default())
serde_json::from_value::<DefaultRuleConfig<Self>>(value).map(DefaultRuleConfig::into_inner)
}

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
Expand Down
Loading