Skip to content

fix(linter): Raise errors for invalid config on eslint/prefer-promise-reject-errors rule #18103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 17, 2026
Merged

fix(linter): Raise errors for invalid config on eslint/prefer-promise-reject-errors rule #18103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions crates/oxc_linter/src/rules/eslint/prefer_promise_reject_errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use oxc_allocator::Box;
use oxc_allocator::Box as ArenaBox;
use oxc_ast::{
AstKind,
ast::{Argument, CallExpression, Expression, FormalParameters},
Expand All @@ -22,7 +22,7 @@ fn prefer_promise_reject_errors_diagnostic(span: Span) -> OxcDiagnostic {
}

#[derive(Debug, Default, Clone, JsonSchema, Deserialize)]
#[serde(rename_all = "camelCase", default)]
#[serde(rename_all = "camelCase", default, deny_unknown_fields)]
pub struct PreferPromiseRejectErrors {
/// Whether to allow calls to `Promise.reject()` with no arguments.
allow_empty_reject: bool,
Expand Down Expand Up @@ -82,9 +82,7 @@ declare_oxc_lint!(

impl Rule for PreferPromiseRejectErrors {
fn from_configuration(value: Value) -> Result<Self, serde_json::error::Error> {
Ok(serde_json::from_value::<DefaultRuleConfig<Self>>(value)
.unwrap_or_default()
.into_inner())
serde_json::from_value::<DefaultRuleConfig<Self>>(value).map(DefaultRuleConfig::into_inner)
}

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
Expand Down Expand Up @@ -141,7 +139,7 @@ fn check_reject_call(call_expr: &CallExpression, ctx: &LintContext, allow_empty_

#[expect(clippy::float_cmp, clippy::cast_precision_loss)]
fn check_reject_in_function(
params: &Box<'_, FormalParameters<'_>>,
params: &ArenaBox<'_, FormalParameters<'_>>,
ctx: &LintContext,
allow_empty_reject: bool,
) {
Expand Down
Loading