fix(formatter): fix 4 prettier conformance tests#18057
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 16, 2026
Merged
fix(formatter): fix 4 prettier conformance tests#18057graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes prettier conformance issues in the JavaScript formatter, improving compatibility from 96.85% to 97.50% (5 additional tests passing).
Changes:
- Improved comment handling for empty statements in loop bodies
- Fixed sequence expression formatting in return/throw statements with leading comments
- Enhanced
letidentifier parenthesization logic for statement context - Optimized ASI protection to avoid unnecessary semicolons for keyword expressions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/prettier_conformance/snapshots/prettier.js.snap.md | Updates test results showing 5 more passing tests and improved match ratios for several others |
| crates/oxc_formatter/src/utils/statement_body.rs | Adds space before empty statements with leading comments |
| crates/oxc_formatter/src/print/return_or_throw_statement.rs | Adds inner parentheses for sequence expressions with leading comments |
| crates/oxc_formatter/src/print/mod.rs | Optimizes ASI protection for keyword expressions and removes redundant comment handling |
| crates/oxc_formatter/src/parentheses/expression.rs | Rewrites let identifier parenthesization logic with comprehensive tree traversal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing Footnotes
|
Dunqing
approved these changes
Jan 16, 2026
Member
|
Needs to run |
Member
Author
Merge activity
|
132253a to
125962d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.