Skip to content

chore(prettier_conformance): update Prettier to 3.8.0#18023

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-15-chore_prettier_conformance_update_prettier_to_3.8
Jan 15, 2026
Merged

chore(prettier_conformance): update Prettier to 3.8.0#18023
graphite-app[bot] merged 1 commit intomainfrom
01-15-chore_prettier_conformance_update_prettier_to_3.8

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 15, 2026

https://prettier.io/blog/2026/01/14/3.8.0

It looks like this version only includes the Angular feature

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 15, 2026
Copy link
Member Author

Dunqing commented Jan 15, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review January 15, 2026 07:31
Copilot AI review requested due to automatic review settings January 15, 2026 07:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Prettier dependency to version 3.8.0 by updating the commit SHA reference and regenerating conformance test snapshots.

Changes:

  • Updated the Prettier commit SHA to version 3.8.0
  • Added 2 new failing TypeScript union comment test cases to the snapshot

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/scripts/clone-parallel.sh Updated PRETTIER_SHA to point to the 3.8.0 release commit
tasks/prettier_conformance/snapshots/prettier.ts.snap.md Updated compatibility statistics and added two new failing test cases for TypeScript union comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this version only includes the Angular feature

It seems so.

But if that's the case, why does the comment format differ..?

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 15, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-15-chore_prettier_conformance_update_prettier_to_3.8 branch from 8c3fca3 to d891108 Compare January 15, 2026 07:43
@leaysgur
Copy link
Member

Anyway, merge first.

I looked at the differences, but it seemed like a niche case.

@Dunqing
Copy link
Member Author

Dunqing commented Jan 15, 2026

Anyway, merge first.

I looked at the differences, but it seemed like a niche case.

Weird! I don't find any related changes from prettier/prettier@3.7.4...3.8.0

@graphite-app graphite-app bot merged commit d891108 into main Jan 15, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 01-15-chore_prettier_conformance_update_prettier_to_3.8 branch January 15, 2026 07:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
@leaysgur
Copy link
Member

leaysgur commented Jan 15, 2026

Ah, it seems these are 3.7.3 > 3.7.4 diffs.

Our conformance was using v3.7.3 (oxfmt was using v3.7.4 tho), and this time updated to 3.7.4 -> 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants