docs(semantic): document with statement limitation in is_global_reference#17996
docs(semantic): document with statement limitation in is_global_reference#17996
with statement limitation in is_global_reference#17996Conversation
…ference` Closes #8365 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation to the is_global_reference function to explain a known limitation with with statements. The documentation clarifies that the function incorrectly returns true for references inside with blocks that may actually resolve to properties of the with object at runtime.
Changes:
- Fixed grammar: "a identifier" → "an identifier"
- Added comprehensive documentation section explaining the
withstatement limitation - Included a code example demonstrating the issue
- Provided justification for why this limitation is acceptable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Summary
Documents the limitation that
is_global_referencedoes not correctly handle references insidewithstatements, as discussed in #8365.The documentation explains:
is_global_referenceincorrectly returnstruefor references insidewithblockswith, bundlers don't support it, minifier bails out)Closes #8365
Test plan
🤖 Generated with Claude Code