Skip to content

fix(parser): improve diagnostics for double export #17992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 14, 2026
Merged

fix(parser): improve diagnostics for double export #17992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/oxc_parser/src/js/module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,18 @@ impl<'a> ParserImpl<'a> {
),
}
}
_ => ModuleDeclaration::ExportNamedDeclaration(
self.parse_export_named_declaration(span, decorators, stmt_ctx),
),
_ => {
if self.at(Kind::Export) {
self.error(diagnostics::modifier_already_seen(&Modifier::new(
self.cur_token().span(),
ModifierKind::Export,
)));
self.bump_any();
}
ModuleDeclaration::ExportNamedDeclaration(
self.parse_export_named_declaration(span, decorators, stmt_ctx),
)
}
};
Statement::from(decl)
}
Expand Down
152 changes: 33 additions & 119 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6065,175 +6065,95 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
· ────────────────
╰────

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:2:12]
1 │ namespace M {
2 │ export export var x = 1;
· ──────
3 │ export export function f() { }
╰────

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:2:12]
1 │ namespace M {
2 │ export export var x = 1;
· ──────
3 │ export export function f() { }
╰────
help: Only 'declare' modifier is allowed here.

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:3:12]
2 │ export export var x = 1;
3 │ export export function f() { }
· ──────
4 │
╰────
help: Remove the duplicate modifier.

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:3:12]
2 │ export export var x = 1;
3 │ export export function f() { }
· ──────
4 │
╰────
help: Allowed modifiers are: declare, async
help: Remove the duplicate modifier.

× TS(1029): 'export' modifier must precede 'declare' modifier.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:5:12]
4 │
5 │ export export namespace N {
· ──────
6 │ export export class C { }
╰────
help: Remove the duplicate modifier.

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:6:16]
5 │ export export namespace N {
6 │ export export class C { }
· ──────
7 │ export export interface I { }
╰────

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:6:16]
5 │ export export namespace N {
6 │ export export class C { }
· ──────
7 │ export export interface I { }
╰────
help: Allowed modifiers are: declare, abstract

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:7:16]
6 │ export export class C { }
7 │ export export interface I { }
· ──────
8 │ }
╰────
help: Remove the duplicate modifier.

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:7:16]
6 │ export export class C { }
7 │ export export interface I { }
· ──────
8 │ }
╰────
help: Only 'declare' modifier is allowed here.

× 'export' modifier cannot be used here.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:5:12]
4 │
5 │ export export namespace N {
· ──────
6 │ export export class C { }
╰────
help: Only 'declare' modifier is allowed here.

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:12:12]
11 │ declare namespace A {
12 │ export export var x;
· ──────
13 │ export export function f()
╰────
help: Remove the duplicate modifier.

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:12:12]
11 │ declare namespace A {
12 │ export export var x;
· ──────
13 │ export export function f()
╰────
help: Only 'declare' modifier is allowed here.

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:13:12]
12 │ export export var x;
13 │ export export function f()
· ──────
14 │
╰────
help: Remove the duplicate modifier.

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:13:12]
12 │ export export var x;
13 │ export export function f()
· ──────
14 │
╰────
help: Allowed modifiers are: declare, async
help: Remove the duplicate modifier.

× TS(1029): 'export' modifier must precede 'declare' modifier.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:15:12]
14 │
15 │ export export namespace N {
· ──────
16 │ export export class C { }
╰────
help: Remove the duplicate modifier.

× TS(1029): 'export' modifier must precede 'declare' modifier.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:16:16]
15 │ export export namespace N {
16 │ export export class C { }
· ──────
17 │ export export interface I { }
╰────
help: Remove the duplicate modifier.

× 'export' modifier cannot be used here.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:16:16]
15 │ export export namespace N {
16 │ export export class C { }
· ──────
17 │ export export interface I { }
╰────
help: Allowed modifiers are: declare, abstract

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:17:16]
16 │ export export class C { }
17 │ export export interface I { }
· ──────
18 │ }
╰────

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:17:16]
16 │ export export class C { }
17 │ export export interface I { }
· ──────
18 │ }
╰────
help: Only 'declare' modifier is allowed here.

× 'export' modifier cannot be used here.
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:15:12]
14 │
15 │ export export namespace N {
· ──────
16 │ export export class C { }
╰────
help: Only 'declare' modifier is allowed here.
help: Remove the duplicate modifier.

× Unexpected token
╭─[typescript/tests/cases/compiler/exportAssignmentWithDeclareAndExportModifiers.ts:2:16]
Expand All @@ -6249,12 +6169,20 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
· ──────
╰────

× Unexpected token
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/compiler/exportAssignmentWithExportModifier.ts:2:8]
1 │ var x;
2 │ export export = x;
· ──────
╰────
help: Remove the duplicate modifier.

× Unexpected token
╭─[typescript/tests/cases/compiler/exportAssignmentWithExportModifier.ts:2:15]
1 │ var x;
2 │ export export = x;
· ─
╰────

× TS(2309): An export assignment cannot be used in a module with other exported elements
╭─[typescript/tests/cases/compiler/exportAssignmentWithExports.ts:3:1]
Expand Down Expand Up @@ -22837,20 +22765,13 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╰────
help: Only 'declare' modifier is allowed here.

× TS(1029): 'export' modifier must precede 'declare' modifier.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration6.ts:1:8]
1 │ export export interface I {
· ──────
2 │ }
╰────

× 'export' modifier cannot be used here.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration6.ts:1:8]
1 │ export export interface I {
· ──────
2 │ }
╰────
help: Only 'declare' modifier is allowed here.
help: Remove the duplicate modifier.

× TS(2414): Interface name cannot be 'string'
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration8.ts:1:11]
Expand Down Expand Up @@ -23361,20 +23282,13 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
3 │ }
╰────

× TS(1029): 'export' modifier must precede 'declare' modifier.
× TS(1030): 'export' modifier already seen.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser618973.ts:1:8]
1 │ export export class Foo {
· ──────
2 │ public Bar() {
╰────

× 'export' modifier cannot be used here.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser618973.ts:1:8]
1 │ export export class Foo {
· ──────
2 │ public Bar() {
╰────
help: Allowed modifiers are: declare, abstract
help: Remove the duplicate modifier.

× The keyword 'static' is reserved
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser642331.ts:2:18]
Expand Down
Loading