fix(codegen): remove spaces around = in minified type parameter defaults#17989
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 14, 2026
Merged
fix(codegen): remove spaces around = in minified type parameter defaults#17989graphite-app[bot] merged 1 commit intomainfrom
= in minified type parameter defaults#17989graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes minified output by removing unnecessary spaces around the = operator in TypeScript type parameter defaults and import equals declarations. The changes leverage the existing print_soft_space() method which only prints spaces in non-minified mode.
Changes:
- Remove spaces around
=in type parameter defaults (e.g.,<Props = any>→<Props=any>) - Remove spaces around
=in TypeScript import equals declarations (e.g.,import a = require("a")→import a=require("a")) - Update test snapshots to reflect the new minified output
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_codegen/src/gen.rs | Replace hardcoded " = " with print_soft_space() + '=' + print_soft_space() in TSTypeParameter and TSImportEqualsDeclaration implementations |
| crates/oxc_codegen/tests/integration/snapshots/minify.snap | Update expected minified output to reflect removal of spaces around = |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…aults (#17989) ## Summary - Remove unnecessary spaces around `=` in type parameter defaults - Remove unnecessary spaces around `=` in import equals declarations ## Changes - `<Props = any>` → `<Props=any>` - `import a = require("a")` → `import a=require("a")` Both syntaxes parse correctly without spaces (verified). ## Test plan - [x] All codegen tests pass - [x] All coverage tests pass (100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
fix/codegen-minify-equals-space
branch
from
e1098fd to
30db4d4
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…aults (#17989) ## Summary - Remove unnecessary spaces around `=` in type parameter defaults - Remove unnecessary spaces around `=` in import equals declarations ## Changes - `<Props = any>` → `<Props=any>` - `import a = require("a")` → `import a=require("a")` Both syntaxes parse correctly without spaces (verified). ## Test plan - [x] All codegen tests pass - [x] All coverage tests pass (100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
fix/codegen-minify-equals-space
branch
from
30db4d4 to
9d83519
Compare
…aults (#17989) ## Summary - Remove unnecessary spaces around `=` in type parameter defaults - Remove unnecessary spaces around `=` in import equals declarations ## Changes - `<Props = any>` → `<Props=any>` - `import a = require("a")` → `import a=require("a")` Both syntaxes parse correctly without spaces (verified). ## Test plan - [x] All codegen tests pass - [x] All coverage tests pass (100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
fix/codegen-minify-equals-space
branch
from
9d83519 to
4c16ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=in type parameter defaults=in import equals declarationsChanges
<Props = any>→<Props=any>import a = require("a")→import a=require("a")Both syntaxes parse correctly without spaces (verified).
Test plan
🤖 Generated with Claude Code