fix(codegen): fix inconsistent multiline EOF comment formatting#17983
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 14, 2026
Merged
fix(codegen): fix inconsistent multiline EOF comment formatting#17983graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes inconsistent multiline EOF comment formatting caused by the print_next_indent_as_space flag leaking from inline comments to EOF comment printing.
Changes:
- Clear the
print_next_indent_as_spaceflag before printing EOF legal comments to ensure consistent formatting - Update snapshot test to reflect the corrected formatting
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_codegen/src/comment.rs | Added flag reset before EOF comment printing to prevent formatting inconsistencies |
| crates/oxc_codegen/tests/integration/snapshots/legal_eof_comments.snap | Updated snapshot to reflect consistent multiline comment formatting without extra leading space |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
## Summary - Clear the `print_next_indent_as_space` flag before printing EOF legal comments to ensure consistent formatting When inline comments set the `print_next_indent_as_space` flag, it was leaking to EOF comment printing, causing inconsistent formatting where some multiline block comments had a leading space before `*` and others didn't. Before: ```js /** * @preserve */ /** * @preserve <-- inconsistent leading space */ ``` After: ```js /** * @preserve */ /** * @preserve */ ``` ## Test plan - Existing tests pass - Snapshot updated to reflect the fix 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
fix/codegen-eof-comment-formatting
branch
from
77c1933 to
1874765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print_next_indent_as_spaceflag before printing EOF legal comments to ensure consistent formattingWhen inline comments set the
print_next_indent_as_spaceflag, it was leaking to EOF comment printing, causing inconsistent formatting where some multiline block comments had a leading space before*and others didn't.Before:
After:
Test plan
🤖 Generated with Claude Code