Skip to content

feat(oxfmt): Add more Oxfmtrc fields description#17979

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-14-feat_oxfmt_add_more_oxfmtrc_docs_description
Jan 14, 2026
Merged

feat(oxfmt): Add more Oxfmtrc fields description#17979
graphite-app[bot] merged 1 commit intomainfrom
01-14-feat_oxfmt_add_more_oxfmtrc_docs_description

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Jan 14, 2026

Added more description with consistent notation.

Copilot AI review requested due to automatic review settings January 14, 2026 04:52
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jan 14, 2026
Copy link
Member Author

leaysgur commented Jan 14, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title feat(oxfmt): Add more Oxfmtrc docs description feat(oxfmt): Add more Oxfmtrc fields description Jan 14, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the documentation for Oxfmt configuration options by adding more detailed descriptions, clarifying default values, and providing additional context for each option. The changes primarily improve the developer experience by making the configuration more understandable.

Changes:

  • Improved documentation format with consistent default value notation (e.g., "- Default: value")
  • Added comprehensive descriptions for experimental sort imports options with detailed explanations of selectors and modifiers
  • Enhanced descriptions for Prettier-compatible options to clarify their behavior across multiple file types
  • Added notes about .editorconfig overrides and feature limitations
  • Standardized "NOTE:" prefix for important information

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
apps/oxfmt/src/core/oxfmtrc.rs Enhanced source documentation for all configuration options with detailed descriptions and consistent formatting
tasks/website_formatter/src/snapshots/schema_markdown.snap Updated markdown snapshot reflecting documentation improvements
tasks/website_formatter/src/snapshots/schema_json.snap Updated JSON schema snapshot with enhanced descriptions
npm/oxfmt/configuration_schema.json Updated NPM package schema with improved documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur force-pushed the 01-14-feat_oxfmt_add_more_oxfmtrc_docs_description branch from d95fcef to 56c3c5b Compare January 14, 2026 05:29
@leaysgur leaysgur force-pushed the 01-14-feat_oxfmt_add_more_oxfmtrc_docs_description branch 3 times, most recently from a906616 to 364b183 Compare January 14, 2026 05:44
@leaysgur leaysgur requested a review from Dunqing January 14, 2026 05:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2026

Merge activity

Added more description with consistent notation.
@graphite-app graphite-app bot force-pushed the 01-14-feat_oxfmt_add_more_oxfmtrc_docs_description branch from 364b183 to 6ffe315 Compare January 14, 2026 07:25
@graphite-app graphite-app bot merged commit 6ffe315 into main Jan 14, 2026
18 checks passed
@graphite-app graphite-app bot deleted the 01-14-feat_oxfmt_add_more_oxfmtrc_docs_description branch January 14, 2026 07:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants