Skip to content

feat(semantic/example): add detailed references info#17938

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-12-feat_semantic_example_add_detailed_references_info
Jan 13, 2026
Merged

feat(semantic/example): add detailed references info#17938
graphite-app[bot] merged 1 commit intomainfrom
c/01-12-feat_semantic_example_add_detailed_references_info

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 12, 2026

Screenshot 2026-01-12 at 18.52.14.png

While possible with the current example infra, it's hard to understand what exactly points where, by reading the ids, and comparing it vs the ast.
This change makes it incredibly easy to identify what symbol a refernce points to.

@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Jan 12, 2026
Copy link
Contributor Author

camc314 commented Jan 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review January 12, 2026 18:52
@camc314 camc314 requested a review from Dunqing as a code owner January 12, 2026 18:52
Copilot AI review requested due to automatic review settings January 12, 2026 18:52
@camc314 camc314 force-pushed the c/01-12-feat_semantic_example_add_detailed_references_info branch from 425b459 to 3a06805 Compare January 12, 2026 18:53
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing c/01-12-feat_semantic_example_add_detailed_references_info (3a06805) with main (63e2737)1

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks2

Footnotes

  1. No successful run was found on main (8d48bd7) during the generation of this report, so 63e2737 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new --symbol-references flag to the semantic analysis example that provides detailed visual diagnostics showing where each symbol is declared and how it's referenced throughout the code. This complements the existing --symbols flag by providing a more graphical, human-readable view of symbol usage using the diagnostic reporting infrastructure.

Changes:

  • Added new CLI flag --symbol-references to display detailed reference information
  • Integrated graphical diagnostic reporting to visualize symbol declarations and references
  • Updated documentation to describe the new option

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
Copy link
Member

Dunqing commented Jan 13, 2026

Merge activity

![Screenshot 2026-01-12 at 18.52.14.png](https://app.graphite.com/user-attachments/assets/f51bc810-1ac3-4561-afac-624dc1b92f1c.png)

While possible with the current example infra, it's hard to understand what exactly points where, by reading the ids, and comparing it vs the ast.
This change makes it incredibly easy to identify what symbol a refernce points to.
@graphite-app graphite-app bot force-pushed the c/01-12-feat_semantic_example_add_detailed_references_info branch from 3a06805 to 6b29bd1 Compare January 13, 2026 02:59
@graphite-app graphite-app bot merged commit 6b29bd1 into main Jan 13, 2026
20 checks passed
@graphite-app graphite-app bot deleted the c/01-12-feat_semantic_example_add_detailed_references_info branch January 13, 2026 03:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants