Skip to content

Comments

fix(linter/no-import-node-test): mark fixer as suggestion#17925

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion
Jan 12, 2026
Merged

fix(linter/no-import-node-test): mark fixer as suggestion#17925
graphite-app[bot] merged 1 commit intomainfrom
c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 12, 2026

fixes #17912

@camc314 camc314 marked this pull request as ready for review January 12, 2026 11:24
Copilot AI review requested due to automatic review settings January 12, 2026 11:24
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jan 12, 2026
Copy link
Contributor Author

camc314 commented Jan 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the no-import-node-test linter rule from providing automatic fixes (applied with --fix) to providing suggestions (applied with --fix-suggestions). The change addresses issue #17912.

Changes:

  • Modified the declare_oxc_lint! macro invocation to specify suggestion instead of fix as the fix capability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1


Comparing c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion (63e2737) with main (896bc17)2

Open in CodSpeed

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (63e2737) during the generation of this report, so 896bc17 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 force-pushed the c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion branch from beeec80 to 1a069fe Compare January 12, 2026 11:33
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 12, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion branch from 1a069fe to 63e2737 Compare January 12, 2026 11:41
@graphite-app graphite-app bot merged commit 63e2737 into main Jan 12, 2026
20 checks passed
@graphite-app graphite-app bot deleted the c/01-12-fix_linter_no-import-node-test_mark_fixer_as_suggestion branch January 12, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: no-import-node-test rule fixer should be marked suggestion or dangerous

1 participant