fix(semantic): allow arguments/eval as binding identifier names and identifier reference names in .d.ts

[Dunqing]

Fixes: #17776

[Dunqing]

• fix(semantic): allow arguments/eval as binding identifier names and identifier reference names in .d.ts #17910 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR fixes semantic checking to allow arguments and eval as binding identifier names and identifier reference names in TypeScript definition files (.d.ts). The fix simplifies the existing logic by adding early returns for .d.ts files, removing the need for complex AST node type checking.

Changes:

• Added early return in check_binding_identifier to skip validation for .d.ts files
• Added early return in check_identifier_reference to skip validation for .d.ts files
• Removed complex special-case logic for TypeScript-specific AST node types
• Added test cases demonstrating usage of arguments and eval in various contexts within .d.ts files

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
tasks/coverage/misc/pass/arguments-eval.d.ts	Added test cases for using arguments and eval as function names, parameters, and in type expressions within a declare global block
crates/oxc_semantic/src/checker/javascript.rs	Added early returns for .d.ts files in identifier validation functions and removed complex TypeScript-specific AST node checking logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-12-fix_semantic_allow_arguments_eval_as_binding_identifier_names_and_identifier_reference_names_in_.d.ts (6be64d9) with main (f1fb048)}

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Merge activity

• Jan 12, 10:02 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 12, 10:02 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Jan 12, 10:09 AM UTC: Merged by the Graphite merge queue.