test(linter/no-promise-executor-return): Regenerate tests for rule.

[connorshea]

The original implementation of the rule did not port most of the tests. I'm not sure that it's worth retaining the previous tests, so I just replaced them entirely for now.

Almost all the tests pass, thankfully, but a few fail and needed to be commented out. We should probably fix them.

Rule was added in #16779.

[Copilot]

Pull request overview

This pull request regenerates comprehensive test coverage for the no-promise-executor-return ESLint rule, replacing the minimal tests from the original implementation. The PR ports the full test suite from ESLint, significantly improving test coverage from approximately 10 test cases to 175 test cases (89 pass cases and 86 fail cases).

Changes:

• Replaced minimal test suite with comprehensive ESLint-sourced tests
• Regenerated snapshot file with 58 error outputs covering all failure scenarios
• Added TODO comments for known limitations with Promise identifier shadowing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_linter/src/snapshots/eslint_no_promise_executor_return.snap	Regenerated snapshot with comprehensive test coverage, expanding from ~30 lines to 408 lines with detailed error messages
crates/oxc_linter/src/rules/eslint/no_promise_executor_return.rs	Replaced minimal test suite with comprehensive tests covering edge cases, arrow functions, nested functions, void expressions, and Promise shadowing scenarios

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks¹

---

_{Comparing regen-tests-for-no-prom (0a1e125) with main (e738353)}

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camchenry]

Looks good to me!

[camchenry]

Merge activity

• Jan 12, 3:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 12, 3:37 AM UTC: camchenry added this pull request to the Graphite merge queue.
• Jan 12, 3:52 AM UTC: Merged by the Graphite merge queue.