Skip to content

fix(linter): add doc url for tsgolint diagnostics #17879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 11, 2026
Merged

fix(linter): add doc url for tsgolint diagnostics #17879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/oxlint/src/lsp/snapshots/fixtures_lsp_tsgolint@no-floating-promises__index.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 1, character: 0 }, end: Position { line: 1, character: 8 } }
related_information[0].message: ""
Expand All @@ -30,7 +30,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 7, character: 0 }, end: Position { line: 7, character: 32 } }
related_information[0].message: ""
Expand All @@ -41,7 +41,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 9, character: 0 }, end: Position { line: 9, character: 32 } }
related_information[0].message: ""
Expand All @@ -52,7 +52,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 11, character: 0 }, end: Position { line: 11, character: 34 } }
related_information[0].message: ""
Expand All @@ -63,7 +63,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "An array of Promises may be unintentional.\nhelp: Consider handling the promises' fulfillment or rejection with Promise.all or similar, or explicitly marking the expression as ignored with the `void` operator."
range: Range { start: Position { line: 13, character: 0 }, end: Position { line: 13, character: 34 } }
related_information[0].message: ""
Expand Down
4 changes: 2 additions & 2 deletions apps/oxlint/src/lsp/snapshots/fixtures_lsp_tsgolint_unused_disabled_directives@test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Linted file: fixtures/lsp/tsgolint/unused_disabled_directives/test.ts
File URI: file://<variable>/fixtures/lsp/tsgolint/unused_disabled_directives/test.ts

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 18, character: 0 }, end: Position { line: 18, character: 9 } }
related_information[0].message: ""
Expand All @@ -19,7 +19,7 @@ source: Some("oxc")
tags: None

code: "typescript-eslint(no-floating-promises)"
code_description.href: "None"
code_description.href: "https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html"
message: "Promises must be awaited.\nhelp: The promise must end with a call to .catch, or end with a call to .then with a rejection handler, or be explicitly marked as ignored with the `void` operator."
range: Range { start: Position { line: 38, character: 0 }, end: Position { line: 38, character: 18 } }
related_information[0].message: ""
Expand Down
4 changes: 2 additions & 2 deletions apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware -c config-test.json@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: --type-aware -c config-test.json
working directory: fixtures/tsgolint
----------

! typescript-eslint(no-floating-promises): Promises must be awaited.
! ]8;;https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html\typescript-eslint(no-floating-promises)]8;;\: Promises must be awaited.
,-[no-floating-promises.ts:2:1]
1 | const promise = new Promise((resolve, _reject) => resolve("value"));
2 | promise;
Expand All @@ -23,7 +23,7 @@ working directory: fixtures/tsgolint
`----
help: Remove the debugger statement

! typescript-eslint(no-floating-promises): Promises must be awaited.
! ]8;;https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-floating-promises.html\typescript-eslint(no-floating-promises)]8;;\: Promises must be awaited.
,-[prefer-promise-reject-errors.ts:1:1]
1 | Promise.reject('error');
: ^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
Loading
Loading