refactor(formatter): simplify the logic for grouping call arguments

[Dunqing]

Pure refactor, early return when possible

[Dunqing]

• fix(formatter): don't wrap parenthesis for type assertion when it's an declaration of export default #17878
• fix(formatter): incorrect type annotation check for short argument #17877
• refactor(formatter): simplify the logic for grouping call arguments #17876 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-11-refactor_formatter_simplify_the_logic_for_grouping_call_arguments (690de75) with main (9699a1b)}

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the logic for grouping call arguments in the formatter to use early returns and simplify the code structure. The goal is to avoid redundant calls to can_group_expression_argument by checking it once and branching based on the result.

Changes:

• Refactored arguments_grouped_layout to use early returns with can_group_expression_argument check
• Removed second_can_group parameter from should_group_first_argument
• Removed last_can_group_fn parameter from should_group_last_argument_impl
• Moved can_group_expression_argument check outside of should_group_last_argument_impl to the caller

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Jan 12, 2:54 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Jan 12, 3:00 AM UTC: Merged by the Graphite merge queue.