Skip to content

fix(linter/tabindex-no-positive): improve diagnostic phrasing #17849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 10, 2026
Merged

fix(linter/tabindex-no-positive): improve diagnostic phrasing #17849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/jsx_a11y/tabindex_no_positive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::{

fn tabindex_no_positive_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Avoid positive integer values for `tabIndex`.")
.with_help("Change the `tabIndex` prop to a non-negative value")
.with_help("Change the `tabIndex` prop to a non-positive value.")
.with_label(span)
}

Expand Down
10 changes: 5 additions & 5 deletions crates/oxc_linter/src/snapshots/jsx_a11y_tabindex_no_positive.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,32 @@ source: crates/oxc_linter/src/tester.rs
1 │ <div tabIndex="1" />
· ────────────
╰────
help: Change the `tabIndex` prop to a non-negative value
help: Change the `tabIndex` prop to a non-positive value.

⚠ eslint-plugin-jsx-a11y(tabindex-no-positive): Avoid positive integer values for `tabIndex`.
╭─[tabindex_no_positive.tsx:1:6]
1 │ <div tabIndex={1} />
· ────────────
╰────
help: Change the `tabIndex` prop to a non-negative value
help: Change the `tabIndex` prop to a non-positive value.

⚠ eslint-plugin-jsx-a11y(tabindex-no-positive): Avoid positive integer values for `tabIndex`.
╭─[tabindex_no_positive.tsx:1:6]
1 │ <div tabIndex={"1"} />
· ──────────────
╰────
help: Change the `tabIndex` prop to a non-negative value
help: Change the `tabIndex` prop to a non-positive value.

⚠ eslint-plugin-jsx-a11y(tabindex-no-positive): Avoid positive integer values for `tabIndex`.
╭─[tabindex_no_positive.tsx:1:6]
1 │ <div tabIndex={`1`} />
· ──────────────
╰────
help: Change the `tabIndex` prop to a non-negative value
help: Change the `tabIndex` prop to a non-positive value.

⚠ eslint-plugin-jsx-a11y(tabindex-no-positive): Avoid positive integer values for `tabIndex`.
╭─[tabindex_no_positive.tsx:1:6]
1 │ <div tabIndex={1.589} />
· ────────────────
╰────
help: Change the `tabIndex` prop to a non-negative value
help: Change the `tabIndex` prop to a non-positive value.
Loading