Skip to content

Comments

refactor(formatter): remove unnecessary MaybeOptionalSemicolon#17796

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-08-refactor_formatter_remove_unnecessary_maybeoptionalsemicolon
Jan 9, 2026
Merged

refactor(formatter): remove unnecessary MaybeOptionalSemicolon#17796
graphite-app[bot] merged 1 commit intomainfrom
01-08-refactor_formatter_remove_unnecessary_maybeoptionalsemicolon

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 8, 2026

MaybeOptionalSemicolon isn't needed

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 8, 2026
Copy link
Member Author

Dunqing commented Jan 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review January 8, 2026 10:22
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-08-refactor_formatter_remove_unnecessary_maybeoptionalsemicolon (d3406f9) with 01-08-refactor_formatter_remove_unnecessary_handling_of_program_directives (7def126)

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jan 9, 2026
Copy link
Member

leaysgur commented Jan 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-08-refactor_formatter_remove_unnecessary_handling_of_program_directives branch from 7def126 to 97ff384 Compare January 9, 2026 08:39
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner January 9, 2026 08:39
@graphite-app graphite-app bot force-pushed the 01-08-refactor_formatter_remove_unnecessary_maybeoptionalsemicolon branch from d3406f9 to b4ed879 Compare January 9, 2026 08:39
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 9, 2026
Base automatically changed from 01-08-refactor_formatter_remove_unnecessary_handling_of_program_directives to main January 9, 2026 08:46
@graphite-app graphite-app bot merged commit b4ed879 into main Jan 9, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 01-08-refactor_formatter_remove_unnecessary_maybeoptionalsemicolon branch January 9, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants