refactor(formatter/sort_imports): Use nodejs-built-in-modules to detect builtin

[leaysgur]

Follow up #17771 (comment)

[leaysgur]

• refactor(formatter/sort_imports): Use nodejs-built-in-modules to detect builtin #17773 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors the import sorting functionality to use the nodejs-built-in-modules crate instead of maintaining a manually-defined list of Node.js builtin modules.

• Replaces a static NODE_BUILTINS PHF set with a call to nodejs_built_in_modules::is_nodejs_builtin_module()
• Adds nodejs-built-in-modules as a workspace dependency to oxc_formatter

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/ir_transform/sort_imports/compute_metadata.rs	Removes the manually-maintained NODE_BUILTINS set and uses the nodejs_built_in_modules crate's function instead
crates/oxc_formatter/Cargo.toml	Adds nodejs-built-in-modules workspace dependency
Cargo.lock	Updates lock file with the new dependency

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

Merging this PR will not alter performance

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks¹

---

_{Comparing 01-08-refactor_formatter_sort_imports_use_nodejs-built-in-modules_to_detect_builtin (98120a9) with main (d7b5c0a)}

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[leaysgur]

Cargo Deny failure is not related to this PR.

  error[unmaintained]: Bincode is unmaintained
  ├ ID: RUSTSEC-2025-0141
  ├ bincode v2.0.1
    └── oxc-browserslist v2.1.5
        └── oxc_compat v0.107.0

Refs: oxc-project/oxc-browserslist#454

[Dunqing]

Merge activity

• Jan 8, 2:49 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 8, 2:49 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Jan 8, 2:56 AM UTC: Merged by the Graphite merge queue.