Skip to content

refactor(oxfmt): Use Box<FormatOptions> for ResolvedOptions #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 8, 2026
Merged

refactor(oxfmt): Use Box<FormatOptions> for ResolvedOptions #17772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/oxfmt/src/core/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ pub fn resolve_editorconfig_path(cwd: &Path) -> Option<PathBuf> {
pub enum ResolvedOptions {
/// For JS/TS files formatted by oxc_formatter.
OxcFormatter {
format_options: FormatOptions,
format_options: Box<FormatOptions>,
/// For embedded language formatting (e.g., CSS in template literals)
external_options: Value,
insert_final_newline: bool,
Expand Down Expand Up @@ -199,7 +199,7 @@ impl ConfigResolver {

match strategy {
FormatFileStrategy::OxcFormatter { .. } => ResolvedOptions::OxcFormatter {
format_options,
format_options: Box::new(format_options),
external_options,
insert_final_newline,
},
Expand Down
2 changes: 1 addition & 1 deletion apps/oxfmt/src/core/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ impl SourceFormatter {
source_text,
path,
*source_type,
format_options,
*format_options,
external_options,
),
insert_final_newline,
Expand Down
Loading