feat(tasks): track memory allocations for oxc_semantic#17758
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Cam / Dunqing I assigned this to both of you, whoever gets there first do they mind reviewing and merging 🙂 Thanks! |
8be23be to
74d6a95
Compare
668a942 to
89ec3a3
Compare
74d6a95 to
cf83648
Compare
cf83648 to
91613ab
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds memory allocation tracking for the oxc_semantic component to the existing memory allocation tracking system. Previously, only parser and minifier allocations were tracked.
Key changes:
- Added semantic allocation tracking between parsing and semantic analysis phases
- Created new snapshot file
allocs_semantic.snapto record semantic allocation metrics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/track_memory_allocations/src/lib.rs | Added semantic_out variable, recorded semantic stats after SemanticBuilder.build(), and wrote semantic snapshot |
| tasks/track_memory_allocations/allocs_semantic.snap | New snapshot file containing semantic allocation metrics for test fixtures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
91613ab to
32b3106
Compare
camchenry
left a comment
There was a problem hiding this comment.
I did originally add the semantic stats tracking in #13012, but stopped as I wanted to get arena allocations too. That ended up being much more difficult so I didn't do it. But I don't see any downside to at least tracking the system allocations here.
Merge activity
|
Maybe there is a reason we didn't have this before 🤔 ? I think it's a useful metric to track though, so this PR adds support for tracking allocations in semantic
32b3106 to
3ebe113
Compare

Maybe there is a reason we didn't have this before 🤔 ?
I think it's a useful metric to track though, so this PR adds support for tracking allocations in semantic