Skip to content

feat(tasks): track memory allocations for oxc_semantic#17758

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic
Jan 8, 2026
Merged

feat(tasks): track memory allocations for oxc_semantic#17758
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 7, 2026

Maybe there is a reason we didn't have this before 🤔 ?

I think it's a useful metric to track though, so this PR adds support for tracking allocations in semantic

Copy link
Contributor Author

camc314 commented Jan 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314
Copy link
Contributor Author

camc314 commented Jan 7, 2026

Cam / Dunqing I assigned this to both of you, whoever gets there first do they mind reviewing and merging 🙂

Thanks!

@camc314 camc314 marked this pull request as ready for review January 7, 2026 16:51
@graphite-app graphite-app bot changed the base branch from c/01-07-chore_ci_run_track_memory_allocations_when_oxc_semantic_changes to graphite-base/17758 January 8, 2026 01:33
@graphite-app graphite-app bot force-pushed the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch from 8be23be to 74d6a95 Compare January 8, 2026 01:42
@graphite-app graphite-app bot force-pushed the graphite-base/17758 branch from 668a942 to 89ec3a3 Compare January 8, 2026 01:42
@graphite-app graphite-app bot changed the base branch from graphite-base/17758 to main January 8, 2026 01:42
@graphite-app graphite-app bot force-pushed the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch from 74d6a95 to cf83648 Compare January 8, 2026 01:43
Copilot AI review requested due to automatic review settings January 8, 2026 02:14
@camchenry camchenry force-pushed the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch from cf83648 to 91613ab Compare January 8, 2026 02:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds memory allocation tracking for the oxc_semantic component to the existing memory allocation tracking system. Previously, only parser and minifier allocations were tracked.

Key changes:

  • Added semantic allocation tracking between parsing and semantic analysis phases
  • Created new snapshot file allocs_semantic.snap to record semantic allocation metrics

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tasks/track_memory_allocations/src/lib.rs Added semantic_out variable, recorded semantic stats after SemanticBuilder.build(), and wrote semantic snapshot
tasks/track_memory_allocations/allocs_semantic.snap New snapshot file containing semantic allocation metrics for test fixtures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camchenry camchenry force-pushed the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch from 91613ab to 32b3106 Compare January 8, 2026 02:20
Copy link
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did originally add the semantic stats tracking in #13012, but stopped as I wanted to get arena allocations too. That ended up being much more difficult so I didn't do it. But I don't see any downside to at least tracking the system allocations here.

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Copy link
Member

camchenry commented Jan 8, 2026

Merge activity

Maybe there is a reason we didn't have this before 🤔 ?

I think it's a useful metric to track though, so this PR adds support for tracking allocations in semantic
@graphite-app graphite-app bot force-pushed the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch from 32b3106 to 3ebe113 Compare January 8, 2026 02:38
@graphite-app graphite-app bot merged commit 3ebe113 into main Jan 8, 2026
18 checks passed
@graphite-app graphite-app bot deleted the c/01-07-feat_tasks_track_memory_allocations_for_oxc_semantic branch January 8, 2026 02:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants