Skip to content

fix(linter): update prefer-destructuring rule metadata #17642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 1 commit into from
Jan 8, 2026
Merged

fix(linter): update prefer-destructuring rule metadata #17642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_linter/src/rules/eslint/prefer_destructuring.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ declare_oxc_lint!(
PreferDestructuring,
eslint,
style,
fix,
conditional_fix,
Copy link
Contributor

@camc314 camc314 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does changing the fix kind fix the issue?

(i'm not saying we shouldn't change this to conditional_fix, just that i don't understand why changing it fixes the issue.

Copy link
Contributor Author

@hamirmahal hamirmahal Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that was the original goal. I'll update the commit message and pull request title now.

Copy link
Contributor

@camc314 camc314 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain in the description how changing the metadata fixes this issue.

config = PreferDestructuring,
);

Expand Down
Loading