feat(linter): implement jsx-a11y/no-noninteractive-element-interactions

[Kenzo-Wada]

related: #1141

• Original docs
• Original source
• Original tests

This PR is published with my friend Claude Code Max(model: opus 4.5). but all reviewed by me, and i am responsible for all the changes.

[Copilot]

Pull request overview

This PR implements the jsx-a11y/no-noninteractive-element-interactions linter rule to enforce accessibility best practices by preventing mouse and keyboard event handlers on non-interactive HTML elements and ARIA roles.

Key changes:

• Adds rule logic to detect event handlers on semantic non-interactive elements (like <li>, <h1>, <article>) and elements with non-interactive ARIA roles
• Distinguishes between interactive and non-interactive roles, with special handling for abstract roles
• Integrates with existing accessibility utilities for screen reader visibility and presentation role detection

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/jsx_a11y/no_noninteractive_element_interactions.rs	Main rule implementation with element/role classification, handler detection logic, and comprehensive test cases
crates/oxc_linter/src/rules.rs	Registers the new rule module in the jsx_a11y rules collection
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds RuleRunner implementation specifying JSXOpeningElement as the target node type
crates/oxc_linter/src/snapshots/jsx_a11y_no_noninteractive_element_interactions.snap	Test snapshot file capturing expected diagnostic output for all test cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing Kenzo-Wada:feat/jsx-a11y-no-noninteractive-element-interactions (980b533) with main (fd2c792)}

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[connorshea]

Updated the PR description with the original docs/source/tests for ease of review :)

[connorshea]

I've implemented is_abstract_role in this PR: #17817, you should update this rule to use it once that PR lands.

[connorshea]

I have now also added is_non_interactive_element and is_interactive_role in that PR. This PR should be updated to use those methods as well to ensure accuracy/consistency once merged.

There are a large number of tests missing in this implementation as well, for example all tests for the recommended options (the recommended config match the defaults in this impl and so should be added/pass), like the one for onCompositionUpdate: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/8f75961d965e47afb88854d324bd32fafde7acfe/__tests__/src/rules/no-noninteractive-element-interactions-test.js#L396

More tests are missing, such as the ones listed in the neverValid array (<dfn onClick={() => {}} />, etc.). The tests must all be ported correctly and made to pass. Unfortunately our rulegen tool does not handle the jsx-a11y rules well, and so this must be done manually.

There is also missing logic, such as an equivalent to the isContentEditable check from the original rule. The tests related to this were ported and do pass, but I assume this is due to a separate logical issue in the code somewhere, and fixing other tests will result in the contenteditable tests failing.

I am assuming this was PR generated using AI tooling, accordingly please update the PR description to note any and all AI usage in accordance with our policy, preferably including models/tools used and a confirmation that you have personally reviewed the code generated and ensured it works/makes sense: https://oxc.rs/docs/contribute/introduction.html#ai-usage-policy

If the PR description is not updated in a timely manner, we will opt to close this PR to avoid maintainer fatigue and prevent spending too much time on contributions not thoroughly reviewed by the contributor.

[Kenzo-Wada]

ill fix it on few days! thanks for your review :)