Skip to content

feat(parser): add TS2528 error code to duplicate_default_export diagnostic #17558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 2, 2026
Merged

feat(parser): add TS2528 error code to duplicate_default_export diagnostic #17558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_parser/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ pub fn duplicate_export(x0: &str, span1: Span, span2: Span) -> OxcDiagnostic {

#[cold]
pub fn duplicate_default_export(spans: impl IntoIterator<Item = Span>) -> OxcDiagnostic {
OxcDiagnostic::error("Duplicated default export").with_labels(spans)
ts_error("2528", "A module cannot have multiple default exports.").with_labels(spans)
}

#[cold]
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/parser_babel.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3331,15 +3331,15 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
· ───────────
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[babel/packages/babel-parser/test/fixtures/es2015/modules/duplicate-export-default/input.js:1:8]
1 │ export default {};
· ───────
2 │ export default function() {};
· ───────
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[babel/packages/babel-parser/test/fixtures/es2015/modules/duplicate-export-default-and-export-as-default/input.js:1:8]
1 │ export default function() {};
· ───────
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/parser_test262.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25195,7 +25195,7 @@ Expect to Parse: tasks/coverage/test262/test/language/statements/using/syntax/us
· ╰── It can not be redeclared here
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[test262/test/language/module-code/early-dup-export-dflt-id.js:18:8]
17 │ var x, y;
18 │ export default x;
Expand Down Expand Up @@ -25234,7 +25234,7 @@ Expect to Parse: tasks/coverage/test262/test/language/statements/using/syntax/us
· ╰── It cannot be redeclared here
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[test262/test/language/module-code/early-dup-export-star-as-dflt.js:18:8]
17 │ var x;
18 │ export default x;
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7241,7 +7241,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
· ───
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[typescript/tests/cases/compiler/jsFileCompilationBindMultipleDefaultExports.ts:1:8]
1 │ export default class a {
· ───────
Expand Down Expand Up @@ -24098,7 +24098,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
13 │ deleted() {
╰────

× Duplicated default export
× TS(2528): A module cannot have multiple default exports.
╭─[typescript/tests/cases/conformance/salsa/plainJSBinderErrors.ts:1:8]
1 │ export default 12
· ───────
Expand Down
Loading