refactor(parser): move duplicate_default_export diagnostic to diagnostics mod

[camc314]

No description provided.

[camc314]

• feat(parser): add TS2528 error code to duplicate_default_export diagnostic #17558
• refactor(parser): move duplicate_default_export diagnostic to diagnostics mod #17557 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors the parser code to move the duplicate_default_export diagnostic creation from inline code in module_record.rs to a dedicated function in the diagnostics.rs module, improving code organization and consistency.

Key changes:

• Extracted inline diagnostic creation into a reusable duplicate_default_export function in the diagnostics module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_parser/src/module_record.rs	Replaced inline OxcDiagnostic::error() call with diagnostics::duplicate_default_export() function call
crates/oxc_parser/src/diagnostics.rs	Added new duplicate_default_export diagnostic function following established patterns with #[cold] attribute

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17557 will not alter performance

_{Comparing c/01-01-refactor_parser_move_duplicate_default_export_diagnostic_to_diagnostics.rs (2f81c86) with main (bb2e8e4)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

Footnotes

1. No successful run was found on main (9200308) during the generation of this report, so bb2e8e4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

Merge activity

• Jan 2, 12:44 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 2, 12:44 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Jan 2, 1:01 PM UTC: Merged by the Graphite merge queue.