feat(minifier): do not flip if/else when it would produce longer result#17556
Merged
Boshen merged 3 commits intooxc-project:mainfrom Jan 15, 2026
Merged
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Contributor
Author
|
i'm not sure why ast changed after last merge, but that seem to be an issue on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable flipping of negated
ifstatement whenalternateisifstatementwhen
if else ifis encountered, flipping always produces at-least one extra character (in many cases 5) as newconsequenthas to be wrapped in{}, this also preventsremove_dead_codeandminimize_statementsto be run to covert if statement's to ternary expression