Skip to content

feat(linter/react): implement no-this-in-sfc #17535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 7 commits into from
Dec 31, 2025
Merged

feat(linter/react): implement no-this-in-sfc #17535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c3cbb87
feat(linter/react): impl react/no-this-in-sfc
Kenzo-Wada Dec 31, 2025
588f4d9
fix insta
Kenzo-Wada Dec 31, 2025
5f0e470
perf
camc314 Dec 31, 2025
7834abc
u
camc314 Dec 31, 2025
e929966
Update apps/oxlint/src/snapshots/fixtures__issue_11644_-c .oxlintrc.j…
camc314 Dec 31, 2025
acc4112
Merge branch 'main' into feat/react-no-this-in-sfc
camc314 Dec 31, 2025
0746983
Update apps/oxlint/src/snapshots/fixtures__issue_11644_-c .oxlintrc.j…
camc314 Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/fixtures__issue_11644_-c .oxlintrc.json@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c .oxlintrc.json
working directory: fixtures/issue_11644
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 165 rules using 1 threads.
Finished in <variable>ms on 1 file with 166 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
6 changes: 6 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2480,6 +2480,12 @@ impl RuleRunner for crate::rules::react::no_string_refs::NoStringRefs {
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::react::no_this_in_sfc::NoThisInSfc {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::ThisExpression]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::react::no_unescaped_entities::NoUnescapedEntities {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::JSXText]));
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ pub(crate) mod react {
pub mod no_render_return_value;
pub mod no_set_state;
pub mod no_string_refs;
pub mod no_this_in_sfc;
pub mod no_unescaped_entities;
pub mod no_unknown_property;
pub mod no_unsafe;
Expand Down Expand Up @@ -1098,6 +1099,7 @@ oxc_macros::declare_all_lint_rules! {
react::no_render_return_value,
react::no_set_state,
react::no_string_refs,
react::no_this_in_sfc,
react::no_unescaped_entities,
react::no_unknown_property,
react::no_unsafe,
Expand Down
Loading
Loading