Skip to content

feat(linter): implement vitest/no-unneeded-async-expect-function rule #17494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 5 commits into from
Jan 6, 2026
Merged

feat(linter): implement vitest/no-unneeded-async-expect-function rule #17494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8040f9
feat(linter): implement vitest/no-unneeded-async-expect-function rule
amondnet Dec 30, 2025
a92b994
fix(linter): improve no-unneeded-async-expect-function tests and docs
amondnet Dec 30, 2025
3816c18
re-port test cases from the original rule
camc314 Jan 2, 2026
1e56dad
fix(linter): enable vitest plugin for no-unneeded-async-expect-functi…
amondnet Jan 5, 2026
993a8d5
u
camc314 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4028,6 +4028,13 @@ impl RuleRunner for crate::rules::vitest::no_import_node_test::NoImportNodeTest
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnce;
}

impl RuleRunner
for crate::rules::vitest::no_unneeded_async_expect_function::NoUnneededAsyncExpectFunction
{
const NODE_TYPES: Option<&AstTypesBitset> = None;
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnJestNode;
}

impl RuleRunner for crate::rules::vitest::prefer_called_times::PreferCalledTimes {
const NODE_TYPES: Option<&AstTypesBitset> = None;
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::RunOnJestNode;
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,7 @@ pub(crate) mod vitest {
pub mod consistent_vitest_vi;
pub mod no_conditional_tests;
pub mod no_import_node_test;
pub mod no_unneeded_async_expect_function;
pub mod prefer_called_times;
pub mod prefer_to_be_falsy;
pub mod prefer_to_be_object;
Expand Down Expand Up @@ -1336,6 +1337,7 @@ oxc_macros::declare_all_lint_rules! {
vitest::consistent_vitest_vi,
vitest::no_conditional_tests,
vitest::no_import_node_test,
vitest::no_unneeded_async_expect_function,
vitest::prefer_called_times,
vitest::prefer_to_be_falsy,
vitest::prefer_to_be_object,
Expand Down
Loading
Loading