Skip to content

feat(oxlint)!: remove oxc_language_server binary #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 29, 2025
+0 −179
Merged

feat(oxlint)!: remove oxc_language_server binary #17457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/release_apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ jobs:
- name: Build Rust binary
run: cross build --release -p oxlint --features allocator --target=${{ matrix.target }}

- name: Build language server
run: cross build --release -p oxc_language_server --bin oxc_language_server --target=${{ matrix.target }}

# The binaries are zipped to fix permission loss https://github.com/actions/upload-artifact#permission-loss
- name: Archive oxlint .node binary
uses: ./.github/actions/archive-binary
Expand All @@ -137,13 +134,6 @@ jobs:
binary_name: oxlint-${{ matrix.code-target }}${{ runner.os == 'Windows' && '.exe' || '' }}
archive_name: rust-oxlint-${{ matrix.code-target }}

- name: Archive language server binary
uses: ./.github/actions/archive-binary
with:
source_path: target/${{ matrix.target }}/release/oxc_language_server${{ runner.os == 'Windows' && '.exe' || '' }}
binary_name: oxc_language_server-${{ matrix.code-target }}${{ runner.os == 'Windows' && '.exe' || '' }}
archive_name: oxc_language_server-${{ matrix.code-target }}

- name: Upload Binary
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
with:
Expand All @@ -152,8 +142,6 @@ jobs:
path: |
oxlint**.zip
oxlint**.tar.gz
oxc_language_server**.zip
oxc_language_server**.tar.gz

# For github release
- name: Upload Binary
Expand Down
1 change: 0 additions & 1 deletion npm/oxfmt/scripts/generate-packages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ function copyDistFiles() {
}

// NOTE: Must update npm/oxfmt/bin/oxfmt
// and npm/oxfmt/bin/oxc_language_server
const TARGETS = [
"win32-x64",
"win32-arm64",
Expand Down
151 changes: 0 additions & 151 deletions npm/oxlint/bin/oxc_language_server
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions npm/oxlint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,12 @@
"url": "https://github.com/sponsors/Boshen"
},
"bin": {
"oxc_language_server": "bin/oxc_language_server",
"oxlint": "bin/oxlint"
},
"files": [
"configuration_schema.json",
"dist",
"README.md",
"bin/oxc_language_server",
"bin/oxlint"
],
"type": "module",
Expand Down
13 changes: 0 additions & 13 deletions npm/oxlint/scripts/generate-packages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { resolve } from "node:path";
import { fileURLToPath } from "node:url";

const OXLINT_BIN_NAME = "oxlint";
const OXLS_BIN_NAME = "oxc_language_server";
/** <REPO ROOT>/npm/oxlint` */
const OXLINT_ROOT = resolve(fileURLToPath(import.meta.url), "../..");
/** `<REPO ROOT>/npm` */
Expand Down Expand Up @@ -60,9 +59,6 @@ function generateNativePackage(target) {
os: [platform],
cpu: [arch],
...libc,
publishConfig: {
executableFiles: ["oxc_language_server"],
},
};

const manifestPath = resolve(packageRoot, "package.json");
Expand All @@ -73,16 +69,8 @@ function generateNativePackage(target) {
const oxlintBinSource = resolve(REPO_ROOT, `${OXLINT_BIN_NAME}.${target}.node`);
const oxlintBinTarget = resolve(packageRoot, `${OXLINT_BIN_NAME}.${target}.node`);

const ext = platform === "win32" ? ".exe" : "";
const oxlsBinSource = resolve(REPO_ROOT, `${OXLS_BIN_NAME}-${target}${ext}`);
const oxlsBinTarget = resolve(packageRoot, `${OXLS_BIN_NAME}${ext}`);

console.log(`Copy linter binary ${oxlintBinSource}`);
fs.copyFileSync(oxlintBinSource, oxlintBinTarget);

console.log(`Copy language server binary ${oxlsBinSource}`);
fs.copyFileSync(oxlsBinSource, oxlsBinTarget);
fs.chmodSync(oxlsBinTarget, 0o755);
}

function writeManifest() {
Expand Down Expand Up @@ -121,7 +109,6 @@ function copyDistFiles() {
fs.cpSync(OXLINT_DIST_SRC, OXLINT_DIST_DEST, { recursive: true });
}

// NOTE: Must update npm/oxlint/bin/oxc_language_server
const TARGETS = [
"win32-x64",
"win32-arm64",
Expand Down
Loading