fix(formatter): incorrect JSX text wrapping when the expression container is an arrow function that will break

[Dunqing]

close: #16956

The mismatch is caused by the expression container (which is an arrow function here) not being wrapped by a group compared to Prettier. After grouping, the output turns into the same.

Input:

<p>
  Current usage for is ${(() => {
    //
  })()}.
</p>

Before output:

<p>
  Current usage for is ${(() => {
    //
  })()}.
</p>;

After output:

<p>
  Current usage for X is $
  {(() => {
    // comment
  })()}
  .
</p>;

Prettier output:

<p>
  Current usage for is $
  {(() => {
    //
  })()}
  .
</p>;

[Dunqing]

• fix(formatter): incorrect JSX text wrapping when the expression container is an arrow function that will break #17445 👈 (View in Graphite)
• fix(formatter): JSXFragment missed a leading semicolon when semicolon is disabled #17386
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17445 will not alter performance

_{Comparing 12-29-fix_formatter_incorrect_jsx_text_wrapping_when_the_expression_container_is_an_arrow_function_that_will_break (5d9ddca) with 12-27-fix_formatter_jsxfragment_is_missing_a_leading_semicolon_when_semicolon_is_disabled (a93d02b)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

I've tested this PR in the opencode repo, and it works well. I am going to merge this without reviewing since leaysgur is on holiday.

[Dunqing]

Merge activity

• Dec 29, 8:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 29, 8:46 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Dec 29, 8:53 AM UTC: Merged by the Graphite merge queue.