perf(semantic): inline enter_kind for TSPropertySignature#17420
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes performance by inlining the enter_kind logic for TSPropertySignature directly into its visit method. This eliminates the overhead of going through the match statement in enter_kind for every TSPropertySignature node.
- The reference flag setting logic is moved from the
enter_kindmethod intovisit_ts_property_signature - The logic is placed after
enter_nodebut before visiting children, maintaining the same behavior - The change follows the same pattern used by similar visit methods like
visit_ts_export_assignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #17420 will not alter performanceComparing Summary
Footnotes
|
330aa71 to
8e803ca
Compare
Merge activity
|

Ref #18098