Skip to content

perf(semantic): inline enter_kind for TSPropertySignature#17420

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tspropertysignature_
Dec 28, 2025
Merged

perf(semantic): inline enter_kind for TSPropertySignature#17420
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tspropertysignature_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2025

Ref #18098

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 28, 2025
@camc314 camc314 marked this pull request as ready for review December 28, 2025 14:13
Copy link
Contributor Author

camc314 commented Dec 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes performance by inlining the enter_kind logic for TSPropertySignature directly into its visit method. This eliminates the overhead of going through the match statement in enter_kind for every TSPropertySignature node.

  • The reference flag setting logic is moved from the enter_kind method into visit_ts_property_signature
  • The logic is placed after enter_node but before visiting children, maintaining the same behavior
  • The change follows the same pattern used by similar visit methods like visit_ts_export_assignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #17420 will not alter performance

Comparing c/12-27-perf_semantic_inline_enter_kind_for_tspropertysignature_ (8e803ca) with main (739ed7c)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (97aef58) during the generation of this report, so 739ed7c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tspropertysignature_ branch from 330aa71 to 8e803ca Compare December 28, 2025 14:21
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 28, 2025

Merge activity

@graphite-app graphite-app bot merged commit 8e803ca into main Dec 28, 2025
28 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_semantic_inline_enter_kind_for_tspropertysignature_ branch December 28, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants