Skip to content

perf(semantic): inline enter_kind for TSTypeAliasDeclaration#17413

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tstypealiasdeclaration_
Dec 28, 2025
Merged

perf(semantic): inline enter_kind for TSTypeAliasDeclaration#17413
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tstypealiasdeclaration_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2025

Ref #18098

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 28, 2025
Copy link
Contributor Author

camc314 commented Dec 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 28, 2025 13:32
@camc314 camc314 requested a review from Dunqing as a code owner December 28, 2025 13:32
Copilot AI review requested due to automatic review settings December 28, 2025 13:32
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #17413 will not alter performance

Comparing c/12-27-perf_semantic_inline_enter_kind_for_tstypealiasdeclaration_ (dc35189) with main (7ec39d0)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (8f98fa0) during the generation of this report, so 7ec39d0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 28, 2025

Merge activity

@camc314 camc314 self-assigned this Dec 28, 2025
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tstypealiasdeclaration_ branch from a31f76c to dc35189 Compare December 28, 2025 13:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the semantic builder by inlining the enter_kind logic for TSTypeAliasDeclaration, reducing function call overhead during AST traversal.

  • Adds a custom visit_ts_type_alias_declaration method that handles the complete visiting logic including binding
  • Removes the TSTypeAliasDeclaration case from the enter_kind method's match statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot merged commit dc35189 into main Dec 28, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_semantic_inline_enter_kind_for_tstypealiasdeclaration_ branch December 28, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants