perf(semantic): inline enter_kind for FormalParameterRest

[camc314]

Ref #18098

[camc314]

• perf(semantic): inline enter_kind for TSModuleDeclaration #17405
• perf(semantic): inline enter_kind for CatchParameter #17404
• perf(semantic): inline enter_kind for FormalParameterRest #17403 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR optimizes the semantic builder by inlining the enter_kind logic for FormalParameterRest, eliminating the overhead of matching in the enter_kind method. A secondary unrelated optimization to the references.retain closure is also included.

• Adds custom visit_formal_parameter_rest method that directly calls param.bind(self) after enter_node
• Removes FormalParameterRest match arm from enter_kind
• Changes references.retain closure parameter from |&reference_id| to |reference_id| with explicit dereference

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17403 will not alter performance

_{Comparing c/12-27-perf_semantic_inline_enter_kind_for_formalparameterrest_ (7284b76) with main (585ddf8)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Dec 27, 10:39 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 27, 10:45 PM UTC: Merged by the Graphite merge queue.