Skip to content

perf(codegen): use print_ascii_byte in more places#17401

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_codegen_use_print_ascii_byte_in_more_places
Dec 28, 2025
Merged

perf(codegen): use print_ascii_byte in more places#17401
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_codegen_use_print_ascii_byte_in_more_places

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 27, 2025

No description provided.

@github-actions github-actions bot added the A-codegen Area - Code Generation label Dec 27, 2025
@camc314 camc314 marked this pull request as ready for review December 27, 2025 21:01
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Dec 27, 2025
Copy link
Contributor Author

camc314 commented Dec 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 self-assigned this Dec 27, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 27, 2025

CodSpeed Performance Report

Merging #17401 will not alter performance

Comparing c/12-27-perf_codegen_use_print_ascii_byte_in_more_places (d2e530b) with c/12-27-perf_codegen_avoid_allocation_in_privateidentifier_gen_when_not_mangling (00f9f8d)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 assigned Boshen and unassigned camc314 Dec 27, 2025
@camc314 camc314 changed the base branch from c/12-27-perf_codegen_avoid_allocation_in_privateidentifier_gen_when_not_mangling to graphite-base/17401 December 27, 2025 21:41
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 28, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/12-27-perf_codegen_use_print_ascii_byte_in_more_places branch from d2e530b to 7ec39d0 Compare December 28, 2025 05:00
@graphite-app graphite-app bot requested a review from Dunqing as a code owner December 28, 2025 05:00
@github-actions github-actions bot added the A-semantic Area - Semantic label Dec 28, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/17401 to c/12-27-perf_codegen_avoid_allocation_in_privateidentifier_gen_when_not_mangling December 28, 2025 05:01
Base automatically changed from c/12-27-perf_codegen_avoid_allocation_in_privateidentifier_gen_when_not_mangling to main December 28, 2025 05:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@graphite-app graphite-app bot merged commit 7ec39d0 into main Dec 28, 2025
23 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_codegen_use_print_ascii_byte_in_more_places branch December 28, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants