Skip to content

perf(mangler): avoid ToString allocations #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 27, 2025
Merged

perf(mangler): avoid ToString allocations #17378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions crates/oxc_mangler/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,12 +574,7 @@ impl<'t> Mangler<'t> {
.elements
.iter()
.map(|class_elements| {
class_elements
.iter()
.filter_map(|element| {
if element.is_private { Some(element.name.to_string()) } else { None }
})
.count()
class_elements.iter().filter(|element| element.is_private).count()
})
.collect();
let parent_private_member_count: IndexVec<ClassId, usize> = classes
Expand Down
2 changes: 1 addition & 1 deletion tasks/track_memory_allocations/allocs_minifier.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cal.com.tsx | 1.06 MB || 40448 | 3032 |

RadixUIAdoptionSection.jsx | 2.52 kB || 85 | 9 || 30 | 6

pdf.mjs | 567.30 kB || 20495 | 2899 || 47453 | 7730
pdf.mjs | 567.30 kB || 20193 | 2899 || 47453 | 7730

antd.js | 6.69 MB || 99534 | 13524 || 331649 | 69358

Expand Down
Loading