fix(formatter): Complete is_complex_type_arguments() (take2)

[leaysgur]

Fixes #17275, without memoized.inspect(f).

[leaysgur]

• fix(formatter): Complete is_complex_type_arguments() (take2) #17362 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR fixes issue #17275 by enhancing the is_complex_type_arguments function to correctly handle nested TSTypeReference types within type arguments. The fix ensures that generic types like Immutable<{...}> are properly recognized as complex, leading to correct line-breaking behavior in the formatter.

Key changes:

• Refactored is_complex_type_arguments to extract the complexity check into a closure for reusability
• Added recursive checking for TSTypeReference types that contain type arguments
• Added comprehensive test case demonstrating the fix for nested generic types

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_formatter/src/utils/assignment_like.rs	Enhanced is_complex_type_arguments to recursively check TSTypeReference types with type arguments, fixing the formatting issue for nested generics
crates/oxc_formatter/tests/fixtures/ts/assignments/complex-type-arguments.ts	Added test case for TSTypeReference with nested type literal to verify the fix
crates/oxc_formatter/tests/fixtures/ts/assignments/complex-type-arguments.ts.snap	Updated snapshot with expected formatting output for the new test case

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17362 will not alter performance

_{Comparing 12-26-fix_formatter_complete_is_complex_type_arguments_take2_ (2b19b83) with main (e8444bf)}

Summary

✅ 38 untouched
⏩ 7 skipped¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

Looks good now!

[Dunqing]

Merge activity

• Dec 26, 3:32 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 26, 3:32 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Dec 26, 3:44 AM UTC: Merged by the Graphite merge queue.