Skip to content

feat(transformer): export ESFeature from options#17347

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-25-feat_transformer_export_esfeature_from_options
Dec 25, 2025
Merged

feat(transformer): export ESFeature from options#17347
graphite-app[bot] merged 1 commit intomainfrom
12-25-feat_transformer_export_esfeature_from_options

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Dec 25, 2025

Rolldown need EngineTargets::has_feature(ESFeature::ES2024UnicodeSetsRegex) to detect js module whether need to be transformed.

See https://github.com/rolldown/rolldown/blob/1e462a32d8bf43178d87b348d930b106bd36a80b/crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs#L128-L131

@shulaoda shulaoda changed the title feat(transformer): export ESFeature from options feat(transformer): export ESFeature from options Dec 25, 2025
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 25, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda marked this pull request as ready for review December 25, 2025 00:29
@shulaoda shulaoda requested review from Boshen and Copilot and removed request for Dunqing, Copilot and overlookmotel December 25, 2025 00:29
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 25, 2025

CodSpeed Performance Report

Merging #17347 will not alter performance

Comparing 12-25-feat_transformer_export_esfeature_from_options (f72cbd5) with main (3506da7)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 25, 2025
Copy link
Member

Dunqing commented Dec 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-25-feat_transformer_export_esfeature_from_options branch from f72cbd5 to 289bff7 Compare December 25, 2025 01:09
@graphite-app graphite-app bot merged commit 289bff7 into main Dec 25, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 12-25-feat_transformer_export_esfeature_from_options branch December 25, 2025 01:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants