perf(linter): jest/no-confusing-set-timeout: do not lowercase import name

[camchenry]

Lowercasing the imported name here causes allocations and is redundant since then explicitly do a case-insensitive ASCII check afterwards. For most (all?) cases, just doing the case-insensitive check should be fine.

(For ASCII, I'm fairly sure these are the same. Of course with Unicode it's much more complicated, but we shouldn't need to worry about that here too much.)

+1% on benchmarks.

[camchenry]

• perf(linter): jest/no-confusing-set-timeout: do not lowercase import name #17324 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17324 will not alter performance

_{Comparing 12-23-perf_linter_jest_no-confusing-set-timeout_do_not_lowercase_import_name (3126f20) with main (b00da37)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (a7d4878) during the generation of this report, so b00da37 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR optimizes the jest/no-confusing-set-timeout linter rule by removing redundant string allocations that were occurring before case-insensitive comparisons. The change eliminates an unnecessary cow_to_ascii_lowercase() call since eq_ignore_ascii_case() already performs case-insensitive ASCII comparison, resulting in a +1% performance improvement on benchmarks.

• Replaced name.cow_to_ascii_lowercase().eq_ignore_ascii_case("jest") with name.eq_ignore_ascii_case("jest")
• Removed the now-unused cow_utils::CowUtils import
• Additional refactoring: consolidated duplicate scoping() calls into a single variable and optimized early return placement in is_jest_fn_call

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 24, 11:14 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 24, 11:14 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 24, 11:20 AM UTC: Merged by the Graphite merge queue.