Skip to content

feat(linter/react): implement react/no-did-mount-set-state #17313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 4 commits into from
Dec 23, 2025
Merged

feat(linter/react): implement react/no-did-mount-set-state #17313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b459ab7
feat(linter/react): implement react/no-did-mount-set-state
Kenzo-Wada Dec 23, 2025
c7ebde9
fix ci error
Kenzo-Wada Dec 23, 2025
f0692d8
update insta
Kenzo-Wada Dec 23, 2025
7a80b12
u
camc314 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/fixtures__issue_11644_-c .oxlintrc.json@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c .oxlintrc.json
working directory: fixtures/issue_11644
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 163 rules using 1 threads.
Finished in <variable>ms on 1 file with 164 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
6 changes: 6 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2408,6 +2408,12 @@ impl RuleRunner for crate::rules::react::no_danger_with_children::NoDangerWithCh
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::react::no_did_mount_set_state::NoDidMountSetState {
const NODE_TYPES: Option<&AstTypesBitset> =
Some(&AstTypesBitset::from_types(&[AstType::CallExpression]));
const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
}

impl RuleRunner for crate::rules::react::no_direct_mutation_state::NoDirectMutationState {
const NODE_TYPES: Option<&AstTypesBitset> = Some(&AstTypesBitset::from_types(&[
AstType::AssignmentExpression,
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ pub(crate) mod react {
pub mod no_children_prop;
pub mod no_danger;
pub mod no_danger_with_children;
pub mod no_did_mount_set_state;
pub mod no_direct_mutation_state;
pub mod no_find_dom_node;
pub mod no_is_mounted;
Expand Down Expand Up @@ -1082,6 +1083,7 @@ oxc_macros::declare_all_lint_rules! {
react::jsx_no_useless_fragment,
react::jsx_props_no_spread_multi,
react::jsx_props_no_spreading,
react::no_did_mount_set_state,
react::no_namespace,
react::no_array_index_key,
react::no_children_prop,
Expand Down
Loading
Loading