fix(rust): remove unsupported tokio io-std feature for WASM compatibility#17311
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 23, 2025
Merged
fix(rust): remove unsupported tokio io-std feature for WASM compatibility#17311graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unsupported io-std tokio feature from packages that don't require it to enable WASM build compatibility. The io-std feature causes WASM builds to fail since it's not supported on WASM targets.
Key changes:
- Removed
io-stdfrom tokio features inoxfmtandoxlintapps where it's not used - Removed
io-stdfrom tokio dev-dependencies inoxc_language_serverwhere tests useDuplexStreaminstead of stdin/stdout - Kept
io-stdinoxc_language_servermain dependencies where it's required for LSP communication
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/oxfmt/Cargo.toml |
Removed io-std from tokio features as the package doesn't use stdin/stdout/stderr |
apps/oxlint/Cargo.toml |
Removed io-std from tokio features as the package doesn't use stdin/stdout/stderr |
crates/oxc_language_server/Cargo.toml |
Removed io-std from dev-dependencies as tests use DuplexStream instead of stdin/stdout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boshen
changed the title
Member
Author
Merge activity
|
…lity (#17311) ## Summary Removes the `io-std` tokio feature from packages that don't require it to fix WASM build compatibility. ## Context The `io-std` feature is not supported on WASM targets, causing builds to fail with: ``` error: Only features sync,macros,io-util,rt,time are supported on wasm. ``` ## Changes - **apps/oxfmt**: Removed `io-std` from tokio features (not used) - **apps/oxlint**: Removed `io-std` from tokio features (not used) - **crates/oxc_language_server**: - Kept `io-std` in main dependencies (required for `tokio::io::stdin()`/`stdout()` for LSP communication) - Removed `io-std` from dev-dependencies (tests use `DuplexStream`) ## Testing - All `oxc_language_server` tests pass (129 tests) - Builds successfully for native targets - Enables WASM builds to proceed
graphite-app
bot
force-pushed
the
fix-wasm-build-remove-io-std
branch
from
c39d89a to
c6690d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
io-stdtokio feature from packages that don't require it to fix WASM build compatibility.Context
The
io-stdfeature is not supported on WASM targets, causing builds to fail with:Changes
io-stdfrom tokio features (not used)io-stdfrom tokio features (not used)io-stdin main dependencies (required fortokio::io::stdin()/stdout()for LSP communication)io-stdfrom dev-dependencies (tests useDuplexStream)Testing
oxc_language_servertests pass (129 tests)