Skip to content

refactor(linter/plugins): rename var in RuleTester#17290

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/12-22-refactor_linter_plugins_rename_var_in_ruletester_
Dec 23, 2025
Merged

refactor(linter/plugins): rename var in RuleTester#17290
graphite-app[bot] merged 1 commit intomainfrom
om/12-22-refactor_linter_plugins_rename_var_in_ruletester_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 23, 2025 •
edited
Loading

Pure refactor. Just rename a var.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 23, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Dec 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 23, 2025
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review December 23, 2025 01:58
Copilot AI review requested due to automatic review settings December 23, 2025 01:58
Copilot AI reviewed Dec 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the RuleTester class by renaming a parameter from alter to modify in the registerModifyTestCaseHook method, improving naming consistency with the surrounding code context.

  • Renamed the parameter alter to modify in the hook registration function to better align with the function name and related variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Dec 23, 2025
@overlookmotel overlookmotel mentioned this pull request Dec 23, 2025
Merged
@camc314
Copy link
Contributor

camc314 commented Dec 23, 2025

As jim's out the rest of the year, i'm going to take over this stack

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 23, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Dec 23, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camc314 camc314 self-assigned this Dec 23, 2025
@graphite-app graphite-app bot force-pushed the om/12-22-refactor_linter_plugins_rename_var_in_ruletester_ branch from 6d1b1d2 to 1dc371e Compare December 23, 2025 10:39
@graphite-app graphite-app bot merged commit 1dc371e into main Dec 23, 2025
18 checks passed
@graphite-app graphite-app bot deleted the om/12-22-refactor_linter_plugins_rename_var_in_ruletester_ branch December 23, 2025 10:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314