feat(oxfmt): Add insertFinalNewline option

[leaysgur]

Fixes #15066 and closes #16757

• Added insertFinalNewline: bool option
  • true by default = The same behavior with current oxc_formatter and Prettier
• Also respect insert_final_newline in .editorconfig
  • Like others, .oxfmtrc takes precedence

[leaysgur]

• feat(oxfmt): Add insertFinalNewline option #17251 👈 (View in Graphite)
• fix(oxfmt): Use correct root dir with ignore and overrides for nested cwd #17244
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17251 will not alter performance

_{Comparing 12-22-feat_oxfmt_add_insertfinalenewline_option (ee42a8b) with main (ab43454)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on 12-22-fix_oxfmt_use_correct_root_dir_with_ignore_and_overrides_for_nested_cwd (fde61bb) during the generation of this report, so main (ab43454) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

Don't need to change the formatter for insertFinalNewLine: false?

[leaysgur]

It's not necessary. Actually, it would be a problem if it were deleted. 😓

oxc/apps/oxfmt/src/core/format.rs

Lines 104 to 108 in ee42a8b

	// NOTE: `insert_final_newline` relies on the fact that:
	// - each formatter already ensures there is traliling newline
	// - each formatter does not have an option to disable trailing newline
	// So we can trim it here without allocating new string.
	if !insert_final_newline {

[Dunqing]

Merge activity

• Dec 22, 8:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 22, 8:55 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Dec 22, 9:02 AM UTC: Merged by the Graphite merge queue.