Skip to content

docs(editor): Improve description for 'no-unused-disable-directives' settings options#17236

Merged
graphite-app[bot] merged 1 commit intomainfrom
vscode-enum-descriptions
Dec 21, 2025
Merged

docs(editor): Improve description for 'no-unused-disable-directives' settings options#17236
graphite-app[bot] merged 1 commit intomainfrom
vscode-enum-descriptions

Conversation

@connorshea
Copy link
Member

Minor improvement since they previously just had descriptions that were the same as the option names.

@connorshea connorshea requested a review from camc314 as a code owner December 21, 2025 21:39
Copilot AI review requested due to automatic review settings December 21, 2025 21:39
@github-actions github-actions bot added A-editor Area - Editor and Language Server C-docs Category - Documentation. Related to user-facing or internal documentation labels Dec 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the documentation for the VSCode extension's oxc.unusedDisableDirectives setting by replacing generic enum descriptions ("Allow", "Warn", "Deny") with detailed explanations of what each option does.

Key Changes:

  • Enhanced enumDescriptions with detailed explanations for each setting option
  • Added markdownEnumDescriptions field with identical content for better editor support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 self-assigned this Dec 21, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 21, 2025
Copy link
Contributor

camc314 commented Dec 21, 2025

Merge activity

…settings options (#17236)

Minor improvement since they previously just had descriptions that were the same as the option names.
@graphite-app graphite-app bot force-pushed the vscode-enum-descriptions branch from f0ec347 to c14afd3 Compare December 21, 2025 21:54
@graphite-app graphite-app bot merged commit c14afd3 into main Dec 21, 2025
19 checks passed
@graphite-app graphite-app bot deleted the vscode-enum-descriptions branch December 21, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-editor Area - Editor and Language Server C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants