feat(vscode): support diagnostic pull mode#17211
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 23, 2025
Merged
Conversation
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for diagnostic pull mode to the VSCode extension, migrating from a custom string-based trigger type to the standardized DiagnosticPullMode enum from vscode-languageclient. This enables proper control over when diagnostics are requested (onChange, onSave, onTabs) through the language server protocol's diagnostic pull model.
Key Changes
- Replaced custom
Triggertype withDiagnosticPullModeenum from vscode-languageclient - Added
diagnosticPullOptionsconfiguration to the language client with filtering logic - Introduced
shouldRequestDiagnosticsmethods to determine when to request diagnostics based on workspace configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
editors/vscode/tests/WorkspaceConfig.spec.ts |
Updated test cases to use DiagnosticPullMode.onSave enum instead of string literal |
editors/vscode/client/tools/linter.ts |
Added diagnosticPullOptions configuration with onChange/onSave flags and filtering logic |
editors/vscode/client/WorkspaceConfig.ts |
Replaced Trigger type with DiagnosticPullMode, updated property types and added shouldRequestDiagnostics method |
editors/vscode/client/ConfigService.ts |
Added shouldRequestDiagnostics method to check if diagnostics should be requested for a given document URI and mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
12-21-feat_oxlint_lsp_support_textdocument_diagnostic_
branch
from
0d09adf to
fc9d078
Compare
Sysix
force-pushed
the
12-21-feat_vscode_support_diagnostic_pull_mode
branch
from
cf709f0 to
33189e4
Compare
camc314
approved these changes
Dec 23, 2025
Contributor
Merge activity
|
The editor implementation for `textDocument/diagnostic`. The client auto enables this request when the server responded with the `DocumentDiagnosticProvider` in `initialize` request. This change only aligns the new pull mode with the extension configuration.
graphite-app
bot
force-pushed
the
12-21-feat_oxlint_lsp_support_textdocument_diagnostic_
branch
from
fc9d078 to
220e8e8
Compare
graphite-app
bot
force-pushed
the
12-21-feat_vscode_support_diagnostic_pull_mode
branch
from
33189e4 to
d9aa426
Compare
Base automatically changed from
12-21-feat_oxlint_lsp_support_textdocument_diagnostic_
to
main
December 23, 2025 17:57
graphite-app
bot
deleted the
12-21-feat_vscode_support_diagnostic_pull_mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor implementation for
textDocument/diagnostic.The client auto enables this request when the server responded with the
DocumentDiagnosticProviderininitializerequest.This change only aligns the new pull mode with the extension configuration.