refactor(linter/plugins): refactor state reset after errors during linting#17206
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 21, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
This was referenced Dec 21, 2025
overlookmotel
force-pushed
the
om/12-20-refactor_linter_plugins_refactor_state_reset_after_errors_during_linting
branch
from
10800a6 to
1fbf13b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors state reset logic after linting operations by introducing a new resetStateAfterError() function that consolidates the cleanup of diagnostics and file-related state. This allows both the main linter and RuleTester to follow the same code path for state resets.
Key changes:
- Replaced the
finallyblock inlintFile()with explicit calls toresetFile()in the success path andresetStateAfterError()in the error path - Created a new exported function
resetStateAfterError()that clears diagnostics and resets file state - Updated
RuleTesterto use the newresetStateAfterError()function instead of manually resetting state
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/lint.ts | Refactored lintFile() to remove finally block and use explicit reset calls; added new resetStateAfterError() function |
| apps/oxlint/src-js/package/rule_tester.ts | Updated to import and use resetStateAfterError() instead of manually resetting diagnostics and calling resetFile() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/12-21-test_linter_plugins_add_ability_to_lint_files_in_deterministic_order
branch
from
857ea37 to
1746050
Compare
overlookmotel
force-pushed
the
om/12-20-refactor_linter_plugins_refactor_state_reset_after_errors_during_linting
branch
from
1fbf13b to
ebd3750
Compare
Contributor
Merge activity
|
…nting (#17206) Pure refactor. Alter how state is reset after linting a file. Move logic for resetting state into a new function `resetStateAfterError` which `RuleTester` can also use. This ensures that `RuleTester` follows the same code path as the actual linter.
graphite-app
bot
force-pushed
the
om/12-21-test_linter_plugins_add_ability_to_lint_files_in_deterministic_order
branch
from
1746050 to
9d6520e
Compare
graphite-app
bot
force-pushed
the
om/12-20-refactor_linter_plugins_refactor_state_reset_after_errors_during_linting
branch
from
ebd3750 to
6f05a99
Compare
Base automatically changed from
om/12-21-test_linter_plugins_add_ability_to_lint_files_in_deterministic_order
to
main
December 21, 2025 14:38
graphite-app
bot
deleted the
om/12-20-refactor_linter_plugins_refactor_state_reset_after_errors_during_linting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Alter how state is reset after linting a file.
Move logic for resetting state into a new function
resetStateAfterErrorwhichRuleTestercan also use. This ensures thatRuleTesterfollows the same code path as the actual linter.