fix(linter): Improve the error message for when the oxlint config file is invalid.#17196
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 21, 2025
Merged
fix(linter): Improve the error message for when the oxlint config file is invalid.#17196graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the error message clarity when oxlint configuration file parsing fails by changing the generic message "Failed to parse configuration file." to the more specific "Failed to parse oxlint configuration file."
- Updated error message in three locations in
lint.rswhere configuration parsing errors are reported - Updated all corresponding test snapshots to reflect the new error message format
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src/lint.rs | Updated error message in three error handling blocks to specify "oxlint configuration file" instead of generic "configuration file" |
| apps/oxlint/test/fixtures/plugin_name_reserved/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/plugin_name_missing2/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/plugin_name_missing/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/plugin_name_alias_reserved/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/plugin_name_alias_invalid/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/missing_rule/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/missing_plugin/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/lint_createOnce_error/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/test/fixtures/import_error/output.snap.md | Updated test snapshot to match new error message |
| apps/oxlint/src/snapshots/fixtures__auto_config_parse_error_debugger.js@oxlint.snap | Updated test snapshot to match new error message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Dec 21, 2025
Contributor
Merge activity
|
…e is invalid. (#17196) It'd be better if the path of the specific invalid config were printed when this happened, in case I'm using nested configs, but for now this improves things a bit, at least.
graphite-app
bot
force-pushed
the
improve-err-msg
branch
from
93c95a0 to
376caf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be better if the path of the specific invalid config were printed when this happened, in case I'm using nested configs, but for now this improves things a bit, at least.