fix(linter): valid-title: fix diagnostic quoted in strings

[camchenry]

The diagnostic messages here were quoted in strings. I also simplified the diagnostic setup to be more conventional like other lint rules where each message has its own function.

[camchenry]

• fix(linter): valid-title: fix diagnostic quoted in strings #17180 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR fixes an issue where diagnostic messages in the valid_title Jest linter rule were incorrectly wrapped in string quotes (using format!("{error_message:?}") and format!("{help_text:?}")). The changes refactor the code to use individual diagnostic functions for each error type, making the code more maintainable and conventional.

Key changes:

• Removed the generic valid_title_diagnostic function and Message enum
• Added six specific diagnostic functions for different error types
• Updated all call sites to use the new diagnostic functions
• Snapshot file updated to show correctly unquoted diagnostic messages

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/rules/jest/valid_title.rs	Refactored diagnostic creation by replacing a generic function and enum with specific diagnostic functions for each error type; updated all usage sites
crates/oxc_linter/src/snapshots/jest_valid_title.snap	Updated snapshot to reflect properly formatted diagnostic messages without extra quotes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17180 will not alter performance

_{Comparing 12-20-fix_linter_fix_diagnostic_quoted_in_strings (78ddd78) with main (8d70b59)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camchenry]

Merge activity

• Dec 20, 3:10 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 20, 3:16 PM UTC: camchenry added this pull request to the Graphite merge queue.
• Dec 20, 3:22 PM UTC: Merged by the Graphite merge queue.