docs(linter/plugin): correct doc comment on getNodeLoc function#17178
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 20, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-docs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates documentation comments in the getNodeLoc function to accurately reflect the current implementation where the loc getter exists on the prototype rather than on individual AST node objects.
Key changes:
- Updated JSDoc comment to clarify that the function "defines" a property rather than "overwrites" a getter
- Expanded inline comments to explain why the property is non-enumerable and non-configurable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/12-20-docs_linter_plugin_correct_doc_comment_on_getnodeloc_function
branch
from
d397ae3 to
4b2ad03
Compare
Contributor
Merge activity
|
…7178) Fix these comments. They were out of date - there's no longer a `loc` getter on AST node objects - the getter is on the prototype. Also alter this function to take a `NodeOrToken`, not `Node` - it's also used for tokens.
graphite-app
bot
force-pushed
the
om/12-20-docs_linter_plugin_correct_doc_comment_on_getnodeloc_function
branch
from
4b2ad03 to
1714719
Compare
graphite-app
bot
deleted the
om/12-20-docs_linter_plugin_correct_doc_comment_on_getnodeloc_function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix these comments. They were out of date - there's no longer a
locgetter on AST node objects - the getter is on the prototype.Also alter this function to take a
NodeOrToken, notNode- it's also used for tokens.