refactor(linter/plugins): add message param to debugAssertIsNonNull#17170
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 20, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
This was referenced Dec 20, 2025
overlookmotel
changed the title
message argument to debugAssertIsNonNullmessage param to debugAssertIsNonNull
camc314
approved these changes
Dec 20, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the debugAssertIsNonNull function to accept an optional message parameter, bringing it into alignment with the similar debugAssert function. This allows developers to provide custom error messages for failed assertions, making debugging easier.
Key changes:
- Added optional
messageparameter todebugAssertIsNonNullthat accepts either a string or a function returning a string - Updated documentation with examples showing lazy message evaluation using a function
- Modified implementation to handle the new message parameter while maintaining backward compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
…l` (#17170) Add `message` param to `debugAssertIsNonNull`, so you can provide a custom error message, same as `debugAssert`.
graphite-app
bot
force-pushed
the
om/12-19-refactor_linter_plugins_add_message_argument_to_debugassertisnonnull_
branch
from
da5af09 to
f0d6b70
Compare
graphite-app
bot
deleted the
om/12-19-refactor_linter_plugins_add_message_argument_to_debugassertisnonnull_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
messageparam todebugAssertIsNonNull, so you can provide a custom error message, same asdebugAssert.